Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python3 venv in Python3-only sonic-mgmt-docker #17337

Merged

Conversation

wsycqyz
Copy link
Contributor

@wsycqyz wsycqyz commented Nov 29, 2023

Why I did it

Work item tracking
  • Microsoft ADO (number only): 25254350

How I did it

Remove Python3 venv in Python3-only sonic-mgmt-docker

How to verify it

There is no impact to sonic-mgmt-docker:latest tag.
Build sonic-mgmt-docker with LEGACY_SONIC_MGMT_DOCKER=y, see python3 venv is there.
Build sonic-mgmt-docker with LEGACY_SONIC_MGMT_DOCKER=n, see python3 venv is NOT included.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@wsycqyz wsycqyz requested a review from lguohan as a code owner November 29, 2023 07:19
@wangxin wangxin merged commit eba6ef0 into sonic-net:master Nov 30, 2023
19 checks passed
@wsycqyz wsycqyz deleted the python3-only-remove-py3-venv-master branch November 30, 2023 04:37
yxieca pushed a commit that referenced this pull request Dec 4, 2023
How I did it
Remove Python3 venv in Python3-only sonic-mgmt-docker

How to verify it
There is no impact to sonic-mgmt-docker:latest tag.
Build sonic-mgmt-docker with LEGACY_SONIC_MGMT_DOCKER=y, see python3 venv is there.
Build sonic-mgmt-docker with LEGACY_SONIC_MGMT_DOCKER=n, see python3 venv is NOT included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants